Changeset eee74cd in buchla-68k

Timestamp:

11/15/2017 08:58:07 PM (6 years ago)

Author:

Thomas Lopatic <thomas@…>

Branches:

master

Children:

f852615

Parents:

f06df21

Message:

Fixed mixed-signedness comparisons.

Location:

ram

Files:

• dec2fr.c (modified) (2 diffs)
• delpnts.c (modified) (1 diff)
• dopatch.c (modified) (1 diff)
• etimlt.c (modified) (1 diff)
• etival.c (modified) (1 diff)
• ptselbx.c (modified) (1 diff)

ram/dec2fr.c

@@ -98 +98 @@
         register int16_t i, p;
 
-        if (v EQ 0x7FFF) {      /* +100 */
+        if (v EQ 32767) {       /* +100 */
 
                 sprintf(s, "100+");
@@ -104 +104 @@
         }
 
-        if (v EQ 0x8000) {      /* -100 */
+        if (v EQ -32768) {      /* -100 */
 
                 sprintf(s, "100-");

ram/delpnts.c

@@ -247 +247 @@
                 fp2 = (int8_t *)&ip->idhpnt[j--];
 
-                for (l = 0; l < sizeof (struct instpnt); l++)
+                for (l = 0; l < (int16_t)sizeof (struct instpnt); l++)
                         *fp1++ = *fp2++;
         }

ram/dopatch.c

@@ -288 +288 @@
                 baseled = lg2base[suba];        /* get base of LED group */
 
-                for (i = 0; i < (3 + (suba & 1)); i++) {        /* scan LEDs */
+                for (i = 0; i < (int16_t)(3 + (suba & 1)); i++) {       /* scan LEDs */
 
                         curled = i + baseled;

ram/etimlt.c

@@ -164 +164 @@
                 tmpval = dec2fr(&ebuf[1]);
 
-                if (tmpval EQ 0xFFFF)
+                if (tmpval EQ -1)
                         return(FAILURE);
                 else

ram/etival.c

@@ -150 +150 @@
                 tmpval = dec2fr(&ebuf[6]);
 
-                if (tmpval EQ 0xFFFF) {
+                if (tmpval EQ -1) {
 
 #if     DEBUGIT

ram/ptselbx.c

@@ -891 +891 @@
                                 ebuf[3] = ptdebuf[42];
 
-                                if (0xFFFF EQ (i = dec2fr(ebuf))) {
+                                if (-1 EQ (i = dec2fr(ebuf))) {
 
                                         badpdat();